The fill tool will fill canvas even when the shape is complete, but will do so outside of previous shapes. Occasionally the fill tool will use a color slightly off, typically by hue and not by pitch. Restarting app works until problem arises again.
Do you have any reproduction steps for you issues? When does this issue occur?
i can try to take a video for you, actually, give me a few hours.
here is a video of the color not being the same between draw and fill despite not re-selecting. I was wrong about it only being in hue, it also changes in saturation. It takes a bit for this to show up, fill tool works perfectly then some time in (in this case 40 minutes) it’ll do this.
I bet the fill tool doesn’t account for gamma correction cause it writes bytes to canvas directly
It does, I specifically wrote gamma correcting code inside flood fill. The weird part, the bug happens “sometimes”
It happens sometimes because I don’t always have pixi open long enough to trigger the bug, it is consistent when I have it open for some time. I can run the test again to see if it happens at smaller run times.
alright this time it happened immediately and I didn’t notice it with my fill shapes until I made a mistake and had to look closer. Fill was a different color than the outline, which was the original color.
Ok I managed to find the issue. It was not the time, but the colors. Some dark low-saturated colors (such as purple on the video) were losing some precision in color calculation process.
Fixed will be in next release
thank you flabbet, you’re amazing!